scsi-bus: Fix transfer length for VERIFY with BYTCHK=11b
authorMarkus Armbruster <armbru@redhat.com>
Wed, 29 Jan 2014 17:47:39 +0000 (18:47 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 22 Feb 2014 09:02:23 +0000 (10:02 +0100)
commit7ef8cf9a0861b6f67f5e57428478c31bfd811651
treedc837d92eb0d893fab0bebd6a402ed43f52bf186
parent703dd81aca15ef1d91dba013b6b66c6e3ff88628
scsi-bus: Fix transfer length for VERIFY with BYTCHK=11b

The transfer length depends on field BYTCHK, which is encoded in byte
1, bits 1..2.  However, the guard for for case BYTCHK=11b doesn't
work, and we get case 01b instead.  Fix it.

Note that since emulated scsi-hd fails the command outright, it takes
SCSI passthrough of a device that actually implements VERIFY with
BYTCHK=11b to make the bug bite.

Screwed up in commit d12ad44.  Spotted by Coverity.

Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/scsi/scsi-bus.c