sched/fair: Do strict inequality check for busiest misfit task group
authorDavid Vernet <void@manifault.com>
Tue, 6 Feb 2024 04:39:20 +0000 (22:39 -0600)
committerIngo Molnar <mingo@kernel.org>
Wed, 28 Feb 2024 14:19:24 +0000 (15:19 +0100)
commit7f1a7229718d788f26a711374da83adc2689837f
tree7fe6e23ba0b197f7f0ed6442bf923ef1c7bdf9fd
parent9dfbc26d27aaf0f5958c5972188f16fe977e5af5
sched/fair: Do strict inequality check for busiest misfit task group

In update_sd_pick_busiest(), when comparing two sched groups that are
both of type group_misfit_task, we currently consider the new group as
busier than the current busiest group even if the new group has the
same misfit task load as the current busiest group. We can avoid some
unnecessary writes if we instead only consider the newest group to be
the busiest if it has a higher load than the current busiest. This
matches the behavior of other group types where we compare load, such as
two groups that are both overloaded.

Let's update the group_misfit_task type comparison to also only update
the busiest group in the event of strict inequality.

Signed-off-by: David Vernet <void@manifault.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20240206043921.850302-3-void@manifault.com
kernel/sched/fair.c