bpf: Remove unnecessary err < 0 check in bpf_struct_ops_map_update_elem
authorMartin KaFai Lau <martin.lau@kernel.org>
Fri, 15 Mar 2024 19:21:12 +0000 (12:21 -0700)
committerAndrii Nakryiko <andrii@kernel.org>
Mon, 18 Mar 2024 19:48:10 +0000 (12:48 -0700)
commit7f3edd0c72c3f7214f8f28495f2e6466348eb128
treea53d58eb46894feba698e54bbb36eb1a5371512f
parent4c8644f86c854c214aaabbcc24a27fa4c7e6a951
bpf: Remove unnecessary err < 0 check in bpf_struct_ops_map_update_elem

There is a "if (err)" check earlier, so the "if (err < 0)"
check that this patch removing is unnecessary. It was my overlook
when making adjustments to the bpf_struct_ops_prepare_trampoline()
such that the caller does not have to worry about the new page when
the function returns error.

Fixes: 187e2af05abe ("bpf: struct_ops supports more than one page for trampolines.")
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20240315192112.2825039-1-martin.lau@linux.dev
kernel/bpf/bpf_struct_ops.c