media: i2c: tda1997: Fix possible use-after-free in tda1997x_remove()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 6 Apr 2021 13:49:45 +0000 (15:49 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Apr 2021 10:54:17 +0000 (12:54 +0200)
commit7f820ab5d4eebfe2d970d32a76ae496a6c286f0f
tree12372223f293e424bb5ded6707bf3233c85189da
parent2c9541720c66899adf6f3600984cf3ef151295ad
media: i2c: tda1997: Fix possible use-after-free in tda1997x_remove()

This driver's remove path calls cancel_delayed_work(). However, that
function does not wait until the work function finishes. This means
that the callback function may still be running after the driver's
remove function has finished, which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
the work is properly cancelled, no longer running, and unable
to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/tda1997x.c