mfd: max14577: Do not enforce (incorrect) interrupt trigger type
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 2 Jun 2021 11:04:45 +0000 (13:04 +0200)
committerLee Jones <lee.jones@linaro.org>
Fri, 5 Nov 2021 14:40:06 +0000 (14:40 +0000)
commit8163fbd97144a488b1edd1776765eec394b0cf17
treee04e7b6bdfdcec8ab012698475e67e502577cd96
parentf5f082eb0486365deab279bb226acdc3f08306b0
mfd: max14577: Do not enforce (incorrect) interrupt trigger type

Interrupt line can be configured on different hardware in different way,
even inverted.  Therefore driver should not enforce specific trigger
type - edge falling - but instead rely on Devicetree to configure it.

The Maxim 14577/77836 datasheets describe the interrupt line as active
low with a requirement of acknowledge from the CPU therefore the edge
falling is not correct.

The interrupt line is shared between PMIC and charger driver, so using
level sensitive interrupt is here especially important to avoid races.
With an edge configuration in case if first PMIC signals interrupt
followed shortly after by the RTC, the interrupt might not be yet
cleared/acked thus the second one would not be noticed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210602110445.33536-4-krzysztof.kozlowski@canonical.com
Documentation/devicetree/bindings/mfd/max14577.txt
drivers/mfd/max14577.c