migration/multifd: Stop changing the packet on recv side
authorFabiano Rosas <farosas@suse.de>
Wed, 28 Aug 2024 14:56:47 +0000 (11:56 -0300)
committerFabiano Rosas <farosas@suse.de>
Tue, 3 Sep 2024 19:24:36 +0000 (16:24 -0300)
commit81b0ed8ad81a9e454ffb77ce028e5081b8b3022f
tree4eaa6dafd5a884d1c3d42edabdf3aa77bb788a32
parent308d165c771b362efd6d3290b9b5bac0a1801563
migration/multifd: Stop changing the packet on recv side

As observed by Philippe, the multifd_ram_unfill_packet() function
currently leaves the MultiFDPacket structure with mixed
endianness. This is harmless, but ultimately not very clean.

Stop touching the received packet and do the necessary work using
stack variables instead.

While here tweak the error strings and fix the space before
semicolons. Also remove the "100 times bigger" comment because it's
just one possible explanation for a size mismatch and it doesn't even
match the code.

CC: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/multifd-nocomp.c
migration/multifd.c