Input: ads7846 - fix integer overflow on Rt calculation
authorOleksij Rempel <o.rempel@pengutronix.de>
Tue, 17 Nov 2020 23:33:24 +0000 (15:33 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Nov 2020 00:28:16 +0000 (16:28 -0800)
commit820830ec918f6c3dcd77a54a1c6198ab57407916
treec9c02b7ed4df1010b0794fb2c5f6a60efe0d1638
parent9c9509717b53e701469493a8d87ed42c7d782502
Input: ads7846 - fix integer overflow on Rt calculation

In some rare cases the 32 bit Rt value will overflow if z2 and x is max,
z1 is minimal value and x_plate_ohms is relatively high (for example 800
ohm). This would happen on some screen age with low pressure.

There are two possible fixes:
- make Rt 64bit
- reorder calculation to avoid overflow

The second variant seems to be preferable, since 64 bit calculation on
32 bit system is a bit more expensive.

Fixes: ffa458c1bd9b6f653008d450f337602f3d52a646 ("spi: ads7846 driver")
Co-developed-by: David Jander <david@protonic.nl>
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20201113112240.1360-1-o.rempel@pengutronix.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/ads7846.c