XArray: Fix xa_for_each with a single element at 0
authorMatthew Wilcox <willy@infradead.org>
Thu, 1 Nov 2018 20:55:19 +0000 (16:55 -0400)
committerMatthew Wilcox <willy@infradead.org>
Mon, 5 Nov 2018 19:56:46 +0000 (14:56 -0500)
commit8229706e03e4147f3e22d1de0d30630cde6d18a9
tree1994f5ff08f7b5c459eba5e26c868ee182d2392a
parent651022382c7f8da46cb4872a545ee1da6d097d2a
XArray: Fix xa_for_each with a single element at 0

The following sequence of calls would result in an infinite loop in
xa_find_after():

xa_store(xa, 0, x, GFP_KERNEL);
index = 0;
xa_for_each(xa, entry, index, ULONG_MAX, XA_PRESENT) { }

xa_find_after() was confusing the situation where we found no entry in
the tree with finding a multiorder entry, so it would look for the
successor entry forever.  Just check for this case explicitly.  Includes
a few new checks in the test suite to be sure this doesn't reappear.

Signed-off-by: Matthew Wilcox <willy@infradead.org>
lib/test_xarray.c
lib/xarray.c