ext4: handle decryption error in __ext4_block_zero_page_range()
authorEric Biggers <ebiggers@google.com>
Thu, 26 Dec 2019 15:41:05 +0000 (09:41 -0600)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 17 Jan 2020 21:24:53 +0000 (16:24 -0500)
commit834f1565fa3f9c8f78adbfcaa80ae510fe4971c3
treece4bcf3c476b6edd1e66975e54965c1bf9b316f7
parent2fdff4c843907e0ad71d6d72d8303bb7199569f7
ext4: handle decryption error in __ext4_block_zero_page_range()

fscrypt_decrypt_pagecache_blocks() can fail, because it uses
skcipher_request_alloc(), which uses kmalloc(), which can fail; and also
because it calls crypto_skcipher_decrypt(), which can fail depending on
the driver that actually implements the crypto.

Therefore it's not appropriate to WARN on decryption error in
__ext4_block_zero_page_range().

Remove the WARN and just handle the error instead.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Link: https://lore.kernel.org/r/20191226154105.4704-1-ebiggers@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c