net, sockmap: Don't call bpf_prog_put() on NULL pointer
authorAlex Dewar <alex.dewar90@gmail.com>
Mon, 12 Oct 2020 17:09:53 +0000 (18:09 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 15 Oct 2020 19:05:23 +0000 (21:05 +0200)
commit83c11c17553c0fca217105c17444c4ef5ab2403f
tree8f1cdaab67e2766fd7d76e634098dc03ce1caf07
parent8a3feed90e75283f15f830b1051bf048e4127c91
net, sockmap: Don't call bpf_prog_put() on NULL pointer

If bpf_prog_inc_not_zero() fails for skb_parser, then bpf_prog_put() is
called unconditionally on skb_verdict, even though it may be NULL. Fix
and tidy up error path.

Fixes: 743df8b7749f ("bpf, sockmap: Check skb_verdict and skb_parser programs explicitly")
Addresses-Coverity-ID: 1497799: Null pointer dereferences (FORWARD_NULL)
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20201012170952.60750-1-alex.dewar90@gmail.com
net/core/sock_map.c