hw/xen: Fix memory leak in libxenstore_open() for Xen
authorDavid Woodhouse <dwmw@amazon.co.uk>
Wed, 12 Apr 2023 18:50:59 +0000 (19:50 +0100)
committerAnthony PERARD <anthony.perard@citrix.com>
Wed, 7 Jun 2023 14:07:10 +0000 (15:07 +0100)
commit8442232eba1b041b379ca5845df8252c1e905e43
tree1064b36a9daf094f1b5e9afd3be17be706136d47
parenteeedfe6c6316e8c0d58becc427e12aceb4cb3ad3
hw/xen: Fix memory leak in libxenstore_open() for Xen

There was a superfluous allocation of the XS handle, leading to it
being leaked on both the error path and the success path (where it gets
allocated again).

Spotted by Coverity (CID 1508098).

Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to internal emulation")
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paul Durrant <paul@xen.org>
Message-Id: <20230412185102.441523-3-dwmw2@infradead.org>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
hw/xen/xen-operations.c