thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister
authorDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 4 Apr 2023 07:51:35 +0000 (09:51 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Fri, 7 Apr 2023 16:36:28 +0000 (18:36 +0200)
commit8454c8c09c7768fd86cda61f1a07b9c746050c80
tree4fca42ea26ec882712c6cb3c52ac90711a554961
parent561538f770a362e704fa0f1b2f2fe78c8e61db6b
thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister

The driver is using the devm_thermal_of_zone_device_register().

In the error path of the function calling
devm_thermal_of_zone_device_register(), the function
devm_thermal_of_zone_unregister() should be called instead of
thermal_of_zone_unregister(), otherwise this one will be called twice
when the device is freed.

The same happens for the remove function where the devm_ guarantee the
thermal_of_zone_unregister() will be called, so adding this call in
the remove function will lead to a double free also.

Use devm_ variant in the error path of the probe function.

Remove thermal_of_zone_unregister() in the remove function.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230404075138.2914680-1-daniel.lezcano@linaro.org
drivers/thermal/broadcom/bcm2835_thermal.c