xfs: short circuit xfs_growfs_data_private() if delta is zero
authorEric Sandeen <sandeen@redhat.com>
Thu, 14 Dec 2023 19:28:08 +0000 (13:28 -0600)
committerChandan Babu R <chandanbabu@kernel.org>
Fri, 15 Dec 2023 03:56:57 +0000 (09:26 +0530)
commit84712492e6dab803bf595fb8494d11098b74a652
treea4071ba8c068e2e7d4d1de209594b9741b03b6dd
parent603ce8ab12094a2d9483c79a7541335e258a5328
xfs: short circuit xfs_growfs_data_private() if delta is zero

Although xfs_growfs_data() doesn't call xfs_growfs_data_private()
if in->newblocks == mp->m_sb.sb_dblocks, xfs_growfs_data_private()
further massages the new block count so that we don't i.e. try
to create a too-small new AG.

This may lead to a delta of "0" in xfs_growfs_data_private(), so
we end up in the shrink case and emit the EXPERIMENTAL warning
even if we're not changing anything at all.

Fix this by returning straightaway if the block delta is zero.

(nb: in older kernels, the result of entering the shrink case
with delta == 0 may actually let an -ENOSPC escape to userspace,
which is confusing for users.)

Fixes: fb2fc1720185 ("xfs: support shrinking unused space in the last AG")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/xfs_fsops.c