vfio/pds: Always clear the save/restore FDs on reset
authorBrett Creeley <brett.creeley@amd.com>
Wed, 28 Feb 2024 00:32:04 +0000 (16:32 -0800)
committerAlex Williamson <alex.williamson@redhat.com>
Fri, 1 Mar 2024 22:46:21 +0000 (15:46 -0700)
commit8512ed256334f6637fc0699ce794792c357544ec
treee14f2c54bc69b8e0c0a92ba0e8b4121a399df58d
parent701ab935859fcfd4a8c8a97f3ee4fb5294a9d481
vfio/pds: Always clear the save/restore FDs on reset

After reset the VFIO device state will always be put in
VFIO_DEVICE_STATE_RUNNING, but the save/restore files will only be
cleared if the previous state was VFIO_DEVICE_STATE_ERROR. This
can/will cause the restore/save files to be leaked if/when the
migration state machine transitions through the states that
re-allocates these files. Fix this by always clearing the
restore/save files for resets.

Fixes: 7dabb1bcd177 ("vfio/pds: Add support for firmware recovery")
Cc: stable@vger.kernel.org
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20240228003205.47311-2-brett.creeley@amd.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/pds/vfio_dev.c