fbdev: fsl-diu-fb: replace deprecated strncpy with strscpy_pad
authorJustin Stitt <justinstitt@google.com>
Wed, 20 Mar 2024 22:48:50 +0000 (22:48 +0000)
committerHelge Deller <deller@gmx.de>
Thu, 25 Apr 2024 09:53:26 +0000 (11:53 +0200)
commit8667a004d6148351a5d66f67889291b8e7466941
tree20531a665dbb0f008aa7c2d6b5f8e0a88123e003
parentfb3b9c2d217f1f51fffe19fc0f4eaf55e2d4ea4f
fbdev: fsl-diu-fb: replace deprecated strncpy with strscpy_pad

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

A better alternative is strscpy() as it guarantees NUL-termination on
the destination buffer.

Since we are eventually copying over to userspace, let's ensure we
NUL-pad the destination buffer by using the pad variant of strscpy.
- core/fb_chrdev.c:
234 | err = copy_to_user(&fix32->id, &fix->id, sizeof(fix32->id));

Furthermore, we can use the new 2-argument variants of strscpy() and
strscpy_pad() introduced by Commit e6584c3964f2f ("string: Allow
2-argument strscpy()") to simplify the syntax even more.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/fsl-diu-fb.c