selinux: fix lsm_get_self_attr()
authorMickaël Salaün <mic@digikod.net>
Fri, 23 Feb 2024 19:05:45 +0000 (20:05 +0100)
committerPaul Moore <paul@paul-moore.com>
Fri, 23 Feb 2024 22:16:33 +0000 (17:16 -0500)
commit86dc9693145bc3b2c21d2bc6a2563376ba8b15ff
tree6a2dd2c623306248118fc6816b80e0f1a086b623
parentd8bdd795d383a23e38ac48a40d3d223caf47b290
selinux: fix lsm_get_self_attr()

selinux_getselfattr() doesn't properly initialize the string pointer
it passes to selinux_lsm_getattr() which can cause a problem when an
attribute hasn't been explicitly set; selinux_lsm_getattr() returns
0/success, but does not set or initialize the string label/attribute.
Failure to properly initialize the string causes problems later in
selinux_getselfattr() when the function attempts to kfree() the
string.

Cc: Casey Schaufler <casey@schaufler-ca.com>
Fixes: 762c934317e6 ("SELinux: Add selfattr hooks")
Suggested-by: Paul Moore <paul@paul-moore.com>
[PM: description changes as discussed in the thread]
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/hooks.c