perf/x86: Fix n_pair for cancelled txn
authorPeter Zijlstra <peterz@infradead.org>
Mon, 5 Oct 2020 08:09:06 +0000 (10:09 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 6 Oct 2020 13:18:17 +0000 (15:18 +0200)
commit871a93b0aad65a7f44ee25f2d17932ef6d559850
treef335936c9c50598f143aebb2436185dddf02b9de
parent59d5396a4666195f89a67e118e9e627ddd6f53a1
perf/x86: Fix n_pair for cancelled txn

Kan reported that n_metric gets corrupted for cancelled transactions;
a similar issue exists for n_pair for AMD's Large Increment thing.

The problem was confirmed and confirmed fixed by Kim using:

  sudo perf stat -e "{cycles,cycles,cycles,cycles}:D" -a sleep 10 &

  # should succeed:
  sudo perf stat -e "{fp_ret_sse_avx_ops.all}:D" -a workload

  # should fail:
  sudo perf stat -e "{fp_ret_sse_avx_ops.all,fp_ret_sse_avx_ops.all,cycles}:D" -a workload

  # previously failed, now succeeds with this patch:
  sudo perf stat -e "{fp_ret_sse_avx_ops.all}:D" -a workload

Fixes: 5738891229a2 ("perf/x86/amd: Add support for Large Increment per Cycle Events")
Reported-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Kim Phillips <kim.phillips@amd.com>
Link: https://lkml.kernel.org/r/20201005082516.GG2628@hirez.programming.kicks-ass.net
arch/x86/events/core.c
arch/x86/events/perf_event.h