hw/isa/ich9: Add comment on imperfect emulation of PIC vs. I/O APIC routing
authorDavid Woodhouse <dwmw@amazon.co.uk>
Wed, 30 Aug 2023 19:59:43 +0000 (20:59 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 4 Oct 2023 16:25:17 +0000 (12:25 -0400)
commit886e0a5f31bf3d40dd8d9199674a4bad64942fde
tree8aaaa69ed13e078bd1b96ff8d6e9fd68cbb5c8e0
parent3d123a8b411706423581db7d26a7bbe548360751
hw/isa/ich9: Add comment on imperfect emulation of PIC vs. I/O APIC routing

As noted in the comment, the PCI INTx lines are supposed to be routed
to *both* the PIC and the I/O APIC. It's just that we don't cope with
the concept of an IRQ being asserted to two *different* pins on the
two irqchips.

So we have this hack of routing to I/O APIC only if the PIRQ routing to
the PIC is disabled. Which seems to work well enough, even when I try
hard to break it with kexec. But should be explicitly documented and
understood.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Message-Id: <112a09643b8191c4eae7d92fa247a861ab90a9ee.camel@infradead.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/isa/lpc_ich9.c