tcg: Remove dh_alias indirection for dh_typecode
authorRichard Henderson <richard.henderson@linaro.org>
Thu, 17 Feb 2022 01:06:22 +0000 (20:06 -0500)
committerRichard Henderson <richard.henderson@linaro.org>
Mon, 28 Feb 2022 18:04:06 +0000 (08:04 -1000)
commit8929906e212cbe606e361cbd32917dcbe5bb6dd0
tree4acc52416554ce423d8cb93f7cc303affa7303a8
parent00483d386901173e84c7965f9f0d678791a75e01
tcg: Remove dh_alias indirection for dh_typecode

The dh_alias redirect is intended to handle TCG types as distinguished
from C types.  TCG does not distinguish signed int from unsigned int,
because they are the same size.  However, we need to retain this
distinction for dh_typecode, lest we fail to extend abi types properly
for the host call parameters.

This bug was detected when running the 'arm' emulator on an s390
system. The s390 uses TCG_TARGET_EXTEND_ARGS which triggers code
in tcg_gen_callN to extend 32 bit values to 64 bits; the incorrect
sign data in the typemask for each argument caused the values to be
extended as unsigned values.

This simple program exhibits the problem:

static volatile int num = -9;
static volatile int den = -5;
int main(void)
{
int quo = num / den;
printf("num %d den %d quo %d\n", num, den, quo);
exit(0);
}

When run on the broken qemu, this results in:

num -9 den -5 quo 0

The correct result is:

num -9 den -5 quo 1

Fixes: 7319d83a735 ("tcg: Combine dh_is_64bit and dh_is_signed to dh_typecode")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/876
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reported-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Tested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Tested-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
include/exec/helper-head.h
target/hppa/helper.h
target/i386/ops_sse_header.h
target/m68k/helper.h
target/ppc/helper.h