pinctrl: mcp23s08: fix race condition in irq handler
authorRadim Pavlik <radim.pavlik@tbs-biometrics.com>
Tue, 1 Jun 2021 10:48:18 +0000 (10:48 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Sun, 6 Jun 2021 22:23:58 +0000 (00:23 +0200)
commit897120d41e7afd9da435cb00041a142aeeb53c07
tree05573ba7f8beb5704b3805cb5a9f8805b7d0dc23
parent50bdc4d44110acb5f45670227b16b9fbbaf08527
pinctrl: mcp23s08: fix race condition in irq handler

Checking value of MCP_INTF in mcp23s08_irq suggests that the handler may be
called even when there is no interrupt pending.

But the actual interrupt could happened between reading MCP_INTF and MCP_GPIO.
In this situation we got nothing from MCP_INTF, but the event gets acknowledged
on the expander by reading MCP_GPIO. This leads to losing events.

Fix the problem by not reading any register until we see something in MCP_INTF.

The error was reproduced and fix tested on MCP23017.

Signed-off-by: Radim Pavlik <radim.pavlik@tbs-biometrics.com>
Link: https://lore.kernel.org/r/AM7PR06MB6769E1183F68DEBB252F665ABA3E9@AM7PR06MB6769.eurprd06.prod.outlook.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-mcp23s08.c