serial: 8250: lock port for omap8250_restore_regs()
authorJohn Ogness <john.ogness@linutronix.de>
Thu, 25 May 2023 09:31:57 +0000 (11:37 +0206)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 May 2023 10:45:42 +0000 (11:45 +0100)
commit8b45503776b6e2c53abbb217970236ed54bd261b
tree175700887bd91e1e4cb81706b39e0e0c46601e48
parent87660fb4041f58d5fdfa58f4d3d35385dcc8320d
serial: 8250: lock port for omap8250_restore_regs()

omap8250_restore_regs() accesses UART_IER. This register is
modified twice by each console write (serial8250_console_write())
under the port lock. However, not all calls to omap8250_restore_regs()
are under the port lock.

Add the missing port locking around omap8250_restore_regs() calls. Add
lockdep notation to the omap8250_restore_regs().

Note that this is not fixing a real problem because the serial devices
are resumed before console printing is enabled.

However, adding this locking allows for clean locking semantics
for omap8250_restore_regs() so that lockdep can be used to identify
possible problems in the future. It also simplifies synchronization
of UART_IER in general by not needing to rely on such implementation
details.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Link: https://lore.kernel.org/r/20230525093159.223817-7-john.ogness@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c