media: rkisp1: params: Fix and simplify (un)registration
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 24 Feb 2022 12:58:40 +0000 (12:58 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 27 Jun 2022 07:01:49 +0000 (08:01 +0100)
commit8ba4862eb59bb2717d8390649cf973a512d892aa
treef48fa7378ab57b636826fe10b38c72b05ab78b48
parentf738cb62a8a7e1bea55e7f7047e2a352f1106f55
media: rkisp1: params: Fix and simplify (un)registration

The rkisp1_params_register() and rkisp1_params_unregister() functions
don't destroy the mutex (in the error path for the former). Fix this,
simplify error handling at registration time as media_entity_cleanup()
can be called on an uninitialized entity, and make
rkisp1_params_unregister() safe to be called on an unregistered params
node to prepare for simplification of error handling at probe time.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-params.c