dm-delay: fix workqueue delay_timer race
authorBenjamin Marzinski <bmarzins@redhat.com>
Tue, 7 May 2024 21:16:23 +0000 (17:16 -0400)
committerMike Snitzer <snitzer@kernel.org>
Thu, 9 May 2024 13:10:58 +0000 (09:10 -0400)
commit8d24790ed08ab4e619ce58ed4a1b353ab77ffdc5
tree1db63ee52f9b4e0b1397c134ee87b7e6a771e8d7
parent83637d9017b22a5e11ada9f44ba776beb807222b
dm-delay: fix workqueue delay_timer race

delay_timer could be pending when delay_dtr() is called. It needs to be
shut down before kdelayd_wq is destroyed, so it won't try queueing more
work to kdelayd_wq while that's getting destroyed.

Also the del_timer_sync() call in delay_presuspend() doesn't protect
against the timer getting immediately rearmed by the queued call to
flush_delayed_bios(), but there's no real harm if that does happen.
timer_delete() is less work, and is basically just as likely to stop a
pointless call to flush_delayed_bios().

Fixes: 26b9f228703f ("dm: delay target")
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-delay.c