hw: Remove unnecessary DEVICE() cast
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Tue, 12 May 2020 07:00:20 +0000 (09:00 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 15 May 2020 05:08:52 +0000 (07:08 +0200)
commit8e5c952b370b57beb642826882c80e1b66a9cf12
tree1fad74d43f0e2e8a6424df685757d67cfbbae02e
parent688ffbb4f72bf9a75c7ff3a899a9617de61d5fd6
hw: Remove unnecessary DEVICE() cast

The DEVICE() macro is defined as:

  #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE)

which expands to:

  ((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name),
                                             __FILE__, __LINE__,
                                             __func__))

This assertion can only fail when @obj points to something other
than its stated type, i.e. when we're in undefined behavior country.

Remove the unnecessary DEVICE() casts when we already know the
pointer is of DeviceState type.

Patch created mechanically using spatch with this script:

  @@
  typedef DeviceState;
  DeviceState *s;
  @@
  -   DEVICE(s)
  +   s

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Paul Durrant <paul@xen.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Acked-by: John Snow <jsnow@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200512070020.22782-4-f4bug@amsat.org>
16 files changed:
hw/display/artist.c
hw/display/cg3.c
hw/display/sm501.c
hw/display/tcx.c
hw/display/vga-isa.c
hw/i2c/imx_i2c.c
hw/i2c/mpc_i2c.c
hw/ide/piix.c
hw/misc/macio/pmu.c
hw/net/ftgmac100.c
hw/net/imx_fec.c
hw/nubus/nubus-device.c
hw/pci-host/bonito.c
hw/ppc/spapr.c
hw/sh4/sh_pci.c
hw/xen/xen-legacy-backend.c