netfilter: use NF_DROP instead of -NF_DROP
authorJason Xing <kernelxing@tencent.com>
Mon, 25 Mar 2024 12:36:14 +0000 (20:36 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 6 May 2024 14:29:21 +0000 (16:29 +0200)
commit8edc27fc4f220179189932cb5f537f2e90a32b87
treeb007b705b15a205a8b39864d30eda64dad2f71f2
parent40616789ec462df0e97ee1d5aa4e4fed4249cae0
netfilter: use NF_DROP instead of -NF_DROP

At the beginning in 2009 one patch [1] introduced collecting drop
counter in nf_conntrack_in() by returning -NF_DROP. Later, another
patch [2] changed the return value of tcp_packet() which now is
renamed to nf_conntrack_tcp_packet() from -NF_DROP to NF_DROP. As
we can see, that -NF_DROP should be corrected.

Similarly, there are other two points where the -NF_DROP is used.

Well, as NF_DROP is equal to 0, inverting NF_DROP makes no sense
as patch [2] said many years ago.

[1]
commit 7d1e04598e5e ("netfilter: nf_conntrack: account packets drop by tcp_packet()")
[2]
commit ec8d540969da ("netfilter: conntrack: fix dropping packet after l4proto->packet()")

Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/iptable_filter.c
net/ipv6/netfilter/ip6table_filter.c
net/netfilter/nf_conntrack_core.c