soundwire: cadence: fix invalid PDI offset
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 26 Mar 2024 09:01:16 +0000 (09:01 +0000)
committerVinod Koul <vkoul@kernel.org>
Fri, 5 Apr 2024 11:49:15 +0000 (17:19 +0530)
commit8ee1b439b1540ae543149b15a2a61b9dff937d91
tree0afb2f4e18f0f30c1dd62d4017de4c30f393777f
parent2a9c6ff5ca5ac074a9f10216e009c042dbba0526
soundwire: cadence: fix invalid PDI offset

For some reason, we add an offset to the PDI, presumably to skip the
PDI0 and PDI1 which are reserved for BPT.

This code is however completely wrong and leads to an out-of-bounds
access. We were just lucky so far since we used only a couple of PDIs
and remained within the PDI array bounds.

A Fixes: tag is not provided since there are no known platforms where
the out-of-bounds would be accessed, and the initial code had problems
as well.

A follow-up patch completely removes this useless offset.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20240326090122.1051806-2-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c