platform/x86: thinkpad_acpi: Do not send ACPI netlink events for unknown hotkeys
authorHans de Goede <hdegoede@redhat.com>
Wed, 24 Apr 2024 12:28:25 +0000 (14:28 +0200)
committerHans de Goede <hdegoede@redhat.com>
Mon, 29 Apr 2024 09:44:13 +0000 (11:44 +0200)
commit8f0215401204cff64a9bcaa950002d4456f7c6b3
tree08d0cbc8c4cd13f9f39673ebc6d7850a9ebbee34
parent56b3667d4ed34fe21de878b49eb964facc75b0d4
platform/x86: thinkpad_acpi: Do not send ACPI netlink events for unknown hotkeys

Do not send ACPI netlink events for unknown hotkeys, to avoid userspace
starting to rely on them. Instead these should be added to the keymap to
send evdev events.

This should not cause a behavior change for existing laptop models since
all currently known 0x1xxx events have a mapping.

In hindsight the ACPI netlink events should have been suppressed for
the adaptive keyboard and extended hotkeys events too. But the kernel has
been sending ACPI netlink events for those for a long time now, so we
cannot just stop sending them without potentially causing issues for
existing users who may depend on these.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240424122834.19801-16-hdegoede@redhat.com
drivers/platform/x86/thinkpad_acpi.c