soundwire: generic_allocation: fix confusion between group and packing
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 23 Mar 2021 05:07:01 +0000 (13:07 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 30 Mar 2021 09:06:11 +0000 (14:36 +0530)
commit8f29bb83586ea993e98b258e1fdb657367dd3c25
treedb8c7a3d364bf5701c5a5035b8ad98670de4e0b4
parent886ce97a36a05e7a9c9d5d894e72d31f50146f5d
soundwire: generic_allocation: fix confusion between group and packing

The existing code makes no sense, we multiply a channel number by
zero (SDW_BLK_GRP_CNT_1), and the result is used to configure the
block packing mode. Sampling grouping and channel packing are two
separate concepts in SoundWire.

In addition, the bandwidth allocation allocates a vertical slice for
each stream, which makes the use of the PER_CHANNEL packing mode
irrelevant.

Let's use the proper definition for block packing mode (PER_PORT).

This change has no functional impact though since the net result is
the same configuration of the DPN_BlockCtrl3 register, when
implemented.

Reported-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210323050701.23760-3-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/generic_bandwidth_allocation.c