nvmet: avoid queuing keep-alive timer if it is disabled
authorHou Pu <houpu.main@gmail.com>
Fri, 16 Apr 2021 02:45:21 +0000 (10:45 +0800)
committerChristoph Hellwig <hch@lst.de>
Wed, 21 Apr 2021 17:13:15 +0000 (19:13 +0200)
commit8f864c595bed20ef85fef3e7314212b73800d51d
tree3dfe784639b677cc6040bf9535ce30f3546e6b21
parentb777f4c47781df6b23e3f4df6fdb92d9aceac7bb
nvmet: avoid queuing keep-alive timer if it is disabled

Issue following command:
nvme set-feature -f 0xf -v 0 /dev/nvme1n1 # disable keep-alive timer
nvme admin-passthru -o 0x18 /dev/nvme1n1  # send keep-alive command
will make keep-alive timer fired and thus delete the controller like
below:

[247459.907635] nvmet: ctrl 1 keep-alive timer (0 seconds) expired!
[247459.930294] nvmet: ctrl 1 fatal error occurred!

Avoid this by not queuing delayed keep-alive if it is disabled when
keep-alive command is received from the admin queue.

Signed-off-by: Hou Pu <houpu.main@gmail.com>
Tested-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/admin-cmd.c