null_blk: Fix null pointer dereference on nullb->disk on blk_cleanup_disk call
authorColin Ian King <colin.king@canonical.com>
Wed, 2 Jun 2021 10:06:59 +0000 (11:06 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 3 Jun 2021 15:54:33 +0000 (09:54 -0600)
commit90bf3e28ef51aa3f480d2f2151813be669ba69ce
tree3a9c1343dc69b41ce8b683674310cca850ec9b4f
parent0e0ccdecb3cff95a350b4364e7ebbaa754d0e47d
null_blk: Fix null pointer dereference on nullb->disk on blk_cleanup_disk call

The error handling on a nullb->disk allocation currently jumps to
out_cleanup_disk that calls blk_cleanup_disk with a null pointer causing
a null pointer dereference issue. Fix this by jumping to out_cleanup_tags
instead.

Addresses-Coverity: ("Dereference after null check")
Fixes: 132226b301b5 ("null_blk: convert to blk_alloc_disk/blk_cleanup_disk")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210602100659.11058-1-colin.king@canonical.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk/main.c