mm/ksm: fix possible UAF of stable_node
authorChengming Zhou <chengming.zhou@linux.dev>
Mon, 13 May 2024 03:07:56 +0000 (11:07 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 24 May 2024 18:55:08 +0000 (11:55 -0700)
commit90e823498881fb8a91d83e9a8eed87c8c3ff2176
tree6e62d929cf84ea3b5b4831c976807c8960801218
parent8cf360b9d6a840700e06864236a01a883b34bbad
mm/ksm: fix possible UAF of stable_node

The commit 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page
deduplication limit") introduced a possible failure case in the
stable_tree_insert(), where we may free the new allocated stable_node_dup
if we fail to prepare the missing chain node.

Then that kfolio return and unlock with a freed stable_node set...  And
any MM activities can come in to access kfolio->mapping, so UAF.

Fix it by moving folio_set_stable_node() to the end after stable_node
is inserted successfully.

Link: https://lkml.kernel.org/r/20240513-b4-ksm-stable-node-uaf-v1-1-f687de76f452@linux.dev
Fixes: 2c653d0ee2ae ("ksm: introduce ksm_max_page_sharing per page deduplication limit")
Signed-off-by: Chengming Zhou <chengming.zhou@linux.dev>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Stefan Roesch <shr@devkernel.io>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/ksm.c