wifi: rtw88: add missing unwind goto for __rtw_download_firmware()
authorPing-Ke Shih <pkshih@realtek.com>
Wed, 7 Jun 2023 01:27:41 +0000 (09:27 +0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 13 Jun 2023 08:36:59 +0000 (11:36 +0300)
commit91ccdbb94feadb0d8bf3b35c841b33ac95f2f45f
tree8872735d7af40c44dabf5f00450fbd55e6f74fed
parentcabb8b48e542e1401f6881c4f7d3bb82f723ee40
wifi: rtw88: add missing unwind goto for __rtw_download_firmware()

This flaw is detected by smatch:
  drivers/net/wireless/realtek/rtw88/mac.c:748 __rtw_download_firmware()
  warn: missing unwind goto?

Though most things of dlfw_fail have been done by
download_firmware_end_flow() and wlan_cpu_enable(), an exception is that
download_firmware_end_flow() clear BIT_MCUFWDL_EN bit conditionally.
So, make this change to clear the bit.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202306052310.OVhcUjZ3-lkp@intel.com/
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230607012741.10353-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw88/mac.c