smb: client: fix potential NULL deref in parse_dfs_referrals()
authorPaulo Alcantara <pc@manguebit.com>
Wed, 6 Dec 2023 00:49:29 +0000 (21:49 -0300)
committerSteve French <stfrench@microsoft.com>
Wed, 6 Dec 2023 03:12:00 +0000 (21:12 -0600)
commit92414333eb375ed64f4ae92d34d579e826936480
tree4b78f81f770cc7a94e1b448c585f25953b5eda9e
parentc54fc3a4f375663f2361a9cbb2955fb4ef912879
smb: client: fix potential NULL deref in parse_dfs_referrals()

If server returned no data for FSCTL_DFS_GET_REFERRALS, @dfs_rsp will
remain NULL and then parse_dfs_referrals() will dereference it.

Fix this by returning -EIO when no output data is returned.

Besides, we can't fix it in SMB2_ioctl() as some FSCTLs are allowed to
return no data as per MS-SMB2 2.2.32.

Fixes: 9d49640a21bf ("CIFS: implement get_dfs_refer for SMB2+")
Cc: stable@vger.kernel.org
Reported-by: Robert Morris <rtm@csail.mit.edu>
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2ops.c