HID: intel-ish-hid: ipc: Fix dev_err usage with uninitialized dev->devc
authorZhang Lixu <lixu.zhang@intel.com>
Wed, 6 Mar 2024 00:44:04 +0000 (00:44 +0000)
committerJiri Kosina <jkosina@suse.com>
Thu, 21 Mar 2024 12:43:33 +0000 (13:43 +0100)
commit92826905ae340b7f2b25759a06c8c60bfc476b9f
treefe540c8c4c9f5e71222cc7bf1d5a8d90f117e163
parent9c0f59e47a90c54d0153f8ddc0f80d7a36207d0e
HID: intel-ish-hid: ipc: Fix dev_err usage with uninitialized dev->devc

The variable dev->devc in ish_dev_init was utilized by dev_err before it
was properly assigned. To rectify this, the assignment of dev->devc has
been moved to immediately follow memory allocation.

Without this change "(NULL device *)" is printed for device information.

Fixes: 8ae2f2b0a284 ("HID: intel-ish-hid: ipc: Fix potential use-after-free in work function")
Fixes: ae02e5d40d5f ("HID: intel-ish-hid: ipc layer")
Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-ish-hid/ipc/ipc.c