mips/boston: Fix boston_mach_init() error handling
authorMarkus Armbruster <armbru@redhat.com>
Tue, 5 May 2020 10:19:05 +0000 (12:19 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 27 May 2020 05:45:41 +0000 (07:45 +0200)
commit932d3a65c8bfe0c260d3564afc082c41febdd882
tree503cc4f73421a6d732ce158a75d007a5ad85133d
parenta729f9bc843a11230d6e7b460b2115e6a55a0f7e
mips/boston: Fix boston_mach_init() error handling

The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

boston_mach_init() is wrong that way.  The last calls treats an error
as fatal.  Do that for the prior ones, too.

Fixes: df1d8a1f29f567567b9d20be685a4241282e7005
Cc: Paul Burton <pburton@wavecomp.com>
Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200505101908.6207-8-armbru@redhat.com>
Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
hw/mips/boston.c