ASoC: SOF: ipc4/intel: Add missing mutex_unlock()
authorJyri Sarha <jyri.sarha@linux.intel.com>
Wed, 22 Mar 2023 18:18:30 +0000 (20:18 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 22 Mar 2023 19:00:30 +0000 (19:00 +0000)
commit935d31fdda2c69324b3eeb648a73fdedf4131474
treeea591b29a5e87c6a657a491e5f8e08753be58da4
parentba31f89c1bf8c297ae411dc6e1659c3b53ef6892
ASoC: SOF: ipc4/intel: Add missing mutex_unlock()

There was a missing mutex_unlock() in sof_ipc4_widget_free()
use_chain_dma if-branch that caused a static analysis error. The
branch should not be used in a normal working configuration and if its
used its an indication of a bad topology. Add missing mutex_unlock()
and a warning print if the if-branch is taken, and another warning
print to a symmetric place in sof_ipc4_widget_setup().

Fixes: ca5ce0caa67fa9 ("ASoC: SOF: ipc4/intel: Add support for chained DMA")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202303222050.dCw0fPCW-lkp@intel.com/
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Link: https://lore.kernel.org/r/20230322181830.574635-1-jyri.sarha@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-topology.c