scsi: ufs: core: Clear cmd if abort succeeds in MCQ mode
authorPeter Wang <peter.wang@mediatek.com>
Wed, 15 Nov 2023 13:10:24 +0000 (21:10 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 25 Nov 2023 01:35:24 +0000 (20:35 -0500)
commit93e6c0e19d5bb12b49534a411c85e21d333731fa
tree922e35b164fbedc69457840b5703c995ec9d20a7
parent2a0508d9d08f0c3e354044d4f48466ee0d225041
scsi: ufs: core: Clear cmd if abort succeeds in MCQ mode

In MCQ mode, if cmd is pending in device and abort succeeds, response will
not be returned by device. So we need clear the cmd, otherwise timeout will
happen and next time we use same tag we will get a WARN_ON(lrbp->cmd).

Below is error log:

  <3>[ 2277.447611][T21376] ufshcd-mtk 112b0000.ufshci: ufshcd_try_to_abort_task: cmd pending in the device. tag = 7
  <3>[ 2277.476954][T21376] ufshcd-mtk 112b0000.ufshci: Aborting tag 7 / CDB 0x2a succeeded
  <6>[ 2307.551263][T30974] ufshcd-mtk 112b0000.ufshci: ufshcd_abort: Device abort task at tag 7
  <4>[ 2307.623264][  T327] WARNING: CPU: 5 PID: 327 at source/drivers/ufs/core/ufshcd.c:3021 ufshcd_queuecommand+0x66c/0xe34

Fixes: ab248643d3d6 ("scsi: ufs: core: Add error handling for MCQ mode")
Cc: <stable@vger.kernel.org>
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Link: https://lore.kernel.org/r/20231115131024.15829-1-peter.wang@mediatek.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c