audit: fix a memleak caused by auditing load module
authorLi RongQing <lirongqing@baidu.com>
Thu, 7 Mar 2019 01:16:24 +0000 (09:16 +0800)
committerPaul Moore <paul@paul-moore.com>
Mon, 18 Mar 2019 23:11:49 +0000 (19:11 -0400)
commit95e0b46fcebd7dbf6850dee96046e4c4ddc7f69c
tree96f51a145ebd0a123a41fe995ee11a0ec526f6bf
parent9e98c678c2d6ae3a17cb2de55d17f69dddaa231b
audit: fix a memleak caused by auditing load module

module.name will be allocated unconditionally when auditing load
module, and audit_log_start() can fail with other reasons, or
audit_log_exit maybe not called, caused module.name is not freed

so free module.name in audit_free_context and __audit_syscall_exit

unreferenced object 0xffff88af90837d20 (size 8):
  comm "modprobe", pid 1036, jiffies 4294704867 (age 3069.138s)
  hex dump (first 8 bytes):
    69 78 67 62 65 00 ff ff                          ixgbe...
  backtrace:
    [<0000000008da28fe>] __audit_log_kern_module+0x33/0x80
    [<00000000c1491e61>] load_module+0x64f/0x3850
    [<000000007fc9ae3f>] __do_sys_init_module+0x218/0x250
    [<0000000000d4a478>] do_syscall_64+0x117/0x400
    [<000000004924ded8>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
    [<000000007dc331dd>] 0xffffffffffffffff

Fixes: ca86cad7380e3 ("audit: log module name on init_module")
Signed-off-by: Zhang Yu <zhangyu31@baidu.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
[PM: manual merge fixup in __audit_syscall_exit()]
Signed-off-by: Paul Moore <paul@paul-moore.com>
kernel/auditsc.c