blockdev: Drop unused drive_get_next()
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Nov 2021 16:34:09 +0000 (17:34 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 15 Dec 2021 13:56:14 +0000 (14:56 +0100)
commit95fd260f0a3663ed229b8e0d2ef111a9f8bd93ad
treed084871d1762db94f372bedcfc36628aea1e31a5
parent8ec239f2d80bed82ad5a361ddfb9ca3560a45ad8
blockdev: Drop unused drive_get_next()

drive_get_next() is basically a bad idea.  It returns the "next" block
backend of a certain interface type.  "Next" means bus=0,unit=N, where
subsequent calls count N up from zero, per interface type.

This lets you define unit numbers implicitly by execution order.  If the
order changes, or new calls appear "in the middle", unit numbers change.
ABI break.  Hard to spot in review.

The previous commits eliminated all uses.  Drop the function.

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20211117163409.3587705-14-armbru@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
blockdev.c
include/sysemu/blockdev.h