drm/nouveau/dp: Fix incorrect return code in r535_dp_aux_xfer()
authorLyude Paul <lyude@redhat.com>
Fri, 15 Mar 2024 21:20:56 +0000 (17:20 -0400)
committerLyude Paul <lyude@redhat.com>
Fri, 15 Mar 2024 22:50:17 +0000 (18:50 -0400)
commit97252d0a4bfbb07079503d059f7522d305fe0f7a
treecedcfe1debe651049bdef22de2633dbe6e8f8dae
parentca3c7819499e633122673246c55ad81e3329100d
drm/nouveau/dp: Fix incorrect return code in r535_dp_aux_xfer()

I've recently been seeing some unexplained GSP errors on my RTX 6000 from
failed aux transactions:

  [  132.915867] nouveau 0000:1f:00.0: gsp: cli:0xc1d00002 obj:0x00730000
  ctrl cmd:0x00731341 failed: 0x0000ffff

While the cause of these is not yet clear, these messages made me notice
that the aux transactions causing these transactions were succeeding - not
failing. As it turns out, this is because we're currently not returning the
correct variable when r535_dp_aux_xfer() hits an error - causing us to
never propagate GSP errors for failed aux transactions to userspace.

So, let's fix that.

Fixes: 4ae3a20102b2 ("nouveau/gsp: don't free ctrl messages on errors")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240315212104.776936-1-lyude@redhat.com
drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c