arm64: dts: qcom: msm8916-samsung-a2015: fix polarity of "enable" line of NFC chip
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Sep 2022 01:15:56 +0000 (18:15 -0700)
committerBjorn Andersson <andersson@kernel.org>
Tue, 18 Oct 2022 03:01:46 +0000 (22:01 -0500)
commit978bc4c578a6d7baffc5646b0f327da036b3051b
treebd7aa3cb53362d9cc0f67fda3cad92bd29139270
parent5aa332c5e7ca2469c9ff55cf294eddb33a2c8e4b
arm64: dts: qcom: msm8916-samsung-a2015: fix polarity of "enable" line of NFC chip

According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
when chip is in use.

s3fwrn5_phy_power_ctrl():

...
gpio_set_value(phy->gpio_en, 1);
...
if (mode != S3FWRN5_MODE_COLD) {
msleep(S3FWRN5_EN_WAIT_TIME);
gpio_set_value(phy->gpio_en, 0);
msleep(S3FWRN5_EN_WAIT_TIME);
}

Therefore the line described by "en-gpios" property should be annotated
as "active low".

The wakeup gpio appears to have correct polarity (active high).

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220929011557.4165216-2-dmitry.torokhov@gmail.com
arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi