i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer
authorTom Rix <trix@redhat.com>
Fri, 4 Sep 2020 18:06:47 +0000 (11:06 -0700)
committerWolfram Sang <wsa@kernel.org>
Mon, 21 Sep 2020 09:45:43 +0000 (11:45 +0200)
commit97c93e06f506107362f1630aa25ec3e3ae71d070
tree1d26f1dd1a394a901c25f8b48aaa66c5531a6dc1
parent703b3228a8fffcadf4651fde527a1b68c693e3a1
i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer

clang static analyzer reports this problem

i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates
  to a garbage value
        return err ? err : num;
               ^~~

err is not initialized, it depends on the being set in the
transfer loop which will not happen if num is 0.  Surveying
other master_xfer() implementations show all handle a 0 num.

Because returning 0 is expected, initialize err to 0.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Elie Morisse <syniurge@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-amd-mp2-plat.c