power: supply: cw2015: Fix potential null-ptr-deref in cw_bat_probe()
authorShang XiaoJing <shangxiaojing@huawei.com>
Thu, 17 Nov 2022 02:45:58 +0000 (10:45 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Thu, 24 Nov 2022 22:00:00 +0000 (23:00 +0100)
commit97f2b4ddb0aa700d673691a7d5e44d226d22bab7
tree01daa223709ca8b32cc1b02c1662245bf289981d
parent955bee204f3dd307642c101b75e370662987e735
power: supply: cw2015: Fix potential null-ptr-deref in cw_bat_probe()

cw_bat_probe() calls create_singlethread_workqueue() and not checked the
ret value, which may return NULL. And a null-ptr-deref may happen:

cw_bat_probe()
    create_singlethread_workqueue() # failed, cw_bat->wq is NULL
    queue_delayed_work()
        queue_delayed_work_on()
            __queue_delayed_work()  # warning here, but continue
                __queue_work()      # access wq->flags, null-ptr-deref

Check the ret value and return -ENOMEM if it is NULL.

Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/cw2015_battery.c