projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2133c4f) | patch
drm/msm/a4xx: fix error handling in a4xx_gpu_init()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 1 Oct 2021 12:57:59 +0000 (15:57 +0300)
committerRob Clark <robdclark@chromium.org>
Tue, 12 Oct 2021 00:30:53 +0000 (17:30 -0700)
commit980d74e7d03ccf2eaa11d133416946bd880c7c08
tree09b682f8256a37f1cb90faa478c520ba1687bdc1tree | snapshot
parent2133c4fc8e1348dcb752f267a143fe2254613b34commit | diff
drm/msm/a4xx: fix error handling in a4xx_gpu_init()

This code returns 1 on error instead of a negative error.  It leads to
an Oops in the caller.  A second problem is that the check for
"if (ret != -ENODATA)" cannot be true because "ret" is set to 1.

Fixes: 5785dd7a8ef0 ("drm/msm: Fix duplicate gpu node in icc summary")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211001125759.GJ2283@kili
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a4xx_gpu.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git