btrfs: dev-replace: properly validate device names
authorDavid Sterba <dsterba@suse.com>
Wed, 14 Feb 2024 15:19:24 +0000 (16:19 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 22 Feb 2024 11:14:21 +0000 (12:14 +0100)
commit9845664b9ee47ce7ee7ea93caf47d39a9d4552c4
tree8d0439b2a57dc289da28ba8fd3df6218e5a65eb6
parent5906333cc4af7b3fdb8cfff1cb3e8e579bd13174
btrfs: dev-replace: properly validate device names

There's a syzbot report that device name buffers passed to device
replace are not properly checked for string termination which could lead
to a read out of bounds in getname_kernel().

Add a helper that validates both source and target device name buffers.
For devid as the source initialize the buffer to empty string in case
something tries to read it later.

This was originally analyzed and fixed in a different way by Edward Adam
Davis (see links).

Link: https://lore.kernel.org/linux-btrfs/000000000000d1a1d1060cc9c5e7@google.com/
Link: https://lore.kernel.org/linux-btrfs/tencent_44CA0665C9836EF9EEC80CB9E7E206DF5206@qq.com/
CC: stable@vger.kernel.org # 4.19+
CC: Edward Adam Davis <eadavis@qq.com>
Reported-and-tested-by: syzbot+33f23b49ac24f986c9e8@syzkaller.appspotmail.com
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c