xfs: fix error bailout in xrep_abt_build_new_trees
authorDarrick J. Wong <djwong@kernel.org>
Mon, 15 Apr 2024 21:54:06 +0000 (14:54 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Mon, 15 Apr 2024 21:54:06 +0000 (14:54 -0700)
commit98a778b42514dcd00c0356b2fbfd458636cbff87
tree78b611ea2f8cd591460cb51dcf7c9d7a3330b121
parent21ad2d03641ae70a7acdcf1212cd135dafb2a798
xfs: fix error bailout in xrep_abt_build_new_trees

Dan Carpenter reports:

"Commit 4bdfd7d15747 ("xfs: repair free space btrees") from Dec 15,
2023 (linux-next), leads to the following Smatch static checker
warning:

        fs/xfs/scrub/alloc_repair.c:781 xrep_abt_build_new_trees()
        warn: missing unwind goto?"

That's a bug, so let's fix it.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: 4bdfd7d15747 ("xfs: repair free space btrees")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/scrub/alloc_repair.c