dmaengine: pl08x: Use kcalloc() instead of kzalloc()
authorErick Archer <erick.archer@outlook.com>
Sat, 30 Mar 2024 15:23:23 +0000 (16:23 +0100)
committerVinod Koul <vkoul@kernel.org>
Wed, 17 Apr 2024 17:13:17 +0000 (22:43 +0530)
commit98f2233a5c20ca567b2db1147278fd110681b9ed
treeb198d0c53f0e62513b6dd415933c9cf5319ba110
parentbd2f66bc0ba08a68c7edcd3992886d1773c18cf2
dmaengine: pl08x: Use kcalloc() instead of kzalloc()

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows [1].

Here the multiplication is obviously safe because the "channels"
member can only be 8 or 2. This value is set when the "vendor_data"
structs are initialized.

static struct vendor_data vendor_pl080 = {
[...]
.channels = 8,
[...]
};

static struct vendor_data vendor_nomadik = {
[...]
.channels = 8,
[...]
};

static struct vendor_data vendor_pl080s = {
[...]
.channels = 8,
[...]
};

static struct vendor_data vendor_pl081 = {
[...]
.channels = 2,
[...]
};

However, using kcalloc() is more appropriate [1] and improves
readability. This patch has no effect on runtime behavior.

Link: https://github.com/KSPP/linux/issues/162
Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Erick Archer <erick.archer@outlook.com>
Link: https://lore.kernel.org/r/AS8PR02MB72373D9261B3B166048A8E218B392@AS8PR02MB7237.eurprd02.prod.outlook.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/amba-pl08x.c