tcg/ppc: Fix tcg_out_rlw_rc
authorDani Szebenyi <szedani@linux.ibm.com>
Tue, 22 Oct 2024 13:34:39 +0000 (15:34 +0200)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 22 Oct 2024 20:45:03 +0000 (13:45 -0700)
commit9a2a5f1b63b11d22a95d3ff800cf7eb5233254e2
tree30e6e7a9c48ce9f71077f0668435f2aa7e4569c2
parent4b7868f8c21cebda86e81f3653e055aa2e87b591
tcg/ppc: Fix tcg_out_rlw_rc

The TCG IR sequence:

  mov_i32 tmp97,$0xc4240000             dead: 1  pref=0xffffffff
  mov_i32 tmp98,$0x0                    pref=0xffffffff
  rotr_i32 tmp97,tmp97,tmp98            dead: 1 2  pref=0xffffffff

was translated to `slwi r15, r14, 0` instead of `slwi r14, r14, 0`
due to SH field overflow.  SH field is 5 bits, and tcg_out_rlw is called
in some situations with `32-n`, when `n` is 0 it results in an overflow
to RA field.

This commit prevents overflow of that field and adds debug assertions
for the other fields

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Dani Szebenyi <szedani@linux.ibm.com>
Message-ID: <20241022133535.69351-2-szedani@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
tcg/ppc/tcg-target.c.inc