f2fs: fix information leak in f2fs_move_inline_dirents()
authorEric Biggers <ebiggers@google.com>
Mon, 23 Jan 2023 07:04:14 +0000 (23:04 -0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 31 Jan 2023 18:47:46 +0000 (10:47 -0800)
commit9a5571cff4ffcfc24847df9fd545cc5799ac0ee5
tree4be04bffc8d40c40e636eb3aa383fdd1dea91d3c
parentb1b9896718bc1a212dc288ad66a5fa2fef11353d
f2fs: fix information leak in f2fs_move_inline_dirents()

When converting an inline directory to a regular one, f2fs is leaking
uninitialized memory to disk because it doesn't initialize the entire
directory block.  Fix this by zero-initializing the block.

This bug was introduced by commit 4ec17d688d74 ("f2fs: avoid unneeded
initializing when converting inline dentry"), which didn't consider the
security implications of leaking uninitialized memory to disk.

This was found by running xfstest generic/435 on a KMSAN-enabled kernel.

Fixes: 4ec17d688d74 ("f2fs: avoid unneeded initializing when converting inline dentry")
Cc: <stable@vger.kernel.org> # v4.3+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/inline.c