net, bpf: Add a warning if NAPI cb missed xdp_do_flush().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 16 Oct 2023 12:57:38 +0000 (14:57 +0200)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 17 Oct 2023 13:02:03 +0000 (15:02 +0200)
commit9a675ba55a96a45a9fb69e6a5c43f80c6682e541
treec7d9260fe55b9ee3be40aae411dcba0a91556e1f
parent137df1189d128a6b5dee2f653e054b40ef36b94c
net, bpf: Add a warning if NAPI cb missed xdp_do_flush().

A few drivers were missing a xdp_do_flush() invocation after
XDP_REDIRECT.

Add three helper functions each for one of the per-CPU lists. Return
true if the per-CPU list is non-empty and flush the list.

Add xdp_do_check_flushed() which invokes each helper functions and
creates a warning if one of the functions had a non-empty list.

Hide everything behind CONFIG_DEBUG_NET.

Suggested-by: Jesper Dangaard Brouer <hawk@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20231016125738.Yt79p1uF@linutronix.de
include/linux/bpf.h
include/net/xdp_sock.h
kernel/bpf/cpumap.c
kernel/bpf/devmap.c
net/core/dev.c
net/core/dev.h
net/core/filter.c
net/xdp/xsk.c